Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug, that stopped execution of local test suite if any of the cond... #3

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix a bug, that stopped execution of local test suite if any of the cond... #3

wants to merge 1 commit into from

Conversation

Inviz
Copy link

@Inviz Inviz commented Nov 13, 2011

...itions fail.

Testling sets browser name to a name of a file, then writes a "fails" group named "node/jsdom" but never uses it.

 /Users/invizko/node_modules/testling/lib/output/text.js:59
         fails[key].push([ 'assert', res ]);
                    ^
 TypeError: Cannot call method 'push' of undefined
     at Handler.assert (/Users/invizko/node_modules/testling/lib/output/text.js:59:20)
     at /Users/invizko/node_modules/testling/lib/output/text.js:9:27
     at EventEmitter.push (/Users/invizko/node_modules/testling/index.js:26:5)
     at EventEmitter.assert (/Users/invizko/node_modules/testling/lib/test.js:64:10)
     at EventEmitter.deepEqual (/Users/invizko/node_modules/testling/lib/test.js:125:10)
     at [object Object].<anonymous> (/Users/invizko/Sites/icl/javascripts/lsd-specs/Testling/output/test.js:21973:34)
     at [object Object].toEqual (/Users/invizko/Sites/icl/javascripts/lsd-specs/Testling/output/test.js:20390:34)
     at [object Object].<anonymous> (/Users/invizko/Sites/icl/javascripts/lsd-specs/Testling/output/test.js:22619:34)
     at /Users/invizko/Sites/icl/javascripts/lsd-specs/Testling/output/test.js:21985:15
     at /Users/invizko/node_modules/testling/lib/test.js:26:5
 invizko:Testling:% mate /Users/invizko/node_modules/testling/lib

@ljharb
Copy link
Collaborator

ljharb commented Jan 10, 2020

@Inviz would you mind checking "allow edits" on the RHS of this PR?

@ljharb ljharb marked this pull request as draft September 19, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Inviz @ljharb